From: Alan Modra <amodra@gmail.com>
Date: Mon, 22 Apr 2024 00:00:38 +0000 (+0930)
Subject: use copy_private_symbol_data in objcopy
X-Git-Tag: gdb-15-branchpoint~287
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e13e2ba45fe23ec4e6d7335b0834290e61605d4d;p=thirdparty%2Fbinutils-gdb.git

use copy_private_symbol_data in objcopy

osympp appearing twice here is not a bug.

	PR 14493
	* objcopy.c (copy_object): Run the symbols through
	bfd_copy_private_symbol_data.
---

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index d91ba123c01..634ebae3fc3 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3380,6 +3380,13 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
       symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
     }
 
+  for (i = 0; i < symcount; i++)
+    if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
+      {
+	status = 1;
+	return false;
+      }
+
   if (dhandle != NULL)
     {
       bool res;