From: William Lallemand <wlallemand@haproxy.com>
Date: Mon, 14 Oct 2019 08:46:58 +0000 (+0200)
Subject: BUG/MEDIUM: ssl: NULL dereference in ssl_sock_load_cert_sni()
X-Git-Tag: v2.1-dev3~85
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e15029bea9a33cc0f7b392bf136ec2e49b17aba7;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: ssl: NULL dereference in ssl_sock_load_cert_sni()

A NULL dereference can occur when inserting SNIs. In the case of
checking for duplicates, if there is already several sni_ctx with the
same key.

Fix issue #321.
---

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 6a781145b7..90df6e7c6f 100644
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -2777,6 +2777,7 @@ static void ssl_sock_load_cert_sni(struct ckch_inst *ckch_inst, struct bind_conf
 				LIST_DEL(&sc0->by_ckch_inst);
 				free(sc0);
 				sc0 = NULL;
+				break;
 			}
 		}