From: Daniel Stenberg <daniel@haxx.se>
Date: Sat, 9 Sep 2017 09:57:17 +0000 (+0200)
Subject: checksrc: verify spaces around equals signs
X-Git-Tag: curl-7_56_0~73
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e155f38d1eaa89cc8ce2a6536b74be2954506bb0;p=thirdparty%2Fcurl.git

checksrc: verify spaces around equals signs

... as the code style mandates.
---

diff --git a/lib/checksrc.pl b/lib/checksrc.pl
index b9fa9362f4..f4ffa1ef38 100755
--- a/lib/checksrc.pl
+++ b/lib/checksrc.pl
@@ -58,7 +58,9 @@ my %warnings = (
     'OPENCOMMENT'      => 'file ended with a /* comment still "open"',
     'ASTERISKSPACE'    => 'pointer declared with space after asterisk',
     'ASTERISKNOSPACE'  => 'pointer declared without space before asterisk',
-    'ASSIGNWITHINCONDITION'  => 'assignment within conditional expression'
+    'ASSIGNWITHINCONDITION'  => 'assignment within conditional expression',
+    'EQUALSNOSPACE'    => 'equals sign without following space',
+    'NOSPACEEQUALS'    => 'equals sign without preceeding space',
     );
 
 sub readwhitelist {
@@ -526,6 +528,20 @@ sub scanfile {
                           "wrongly placed open brace");
             }
         }
+
+        # check for equals sign without spaces next to it
+        if($nostr =~ /(.*)\=[a-z0-9]/i) {
+            checkwarn("EQUALSNOSPACE",
+                      $line, length($1)+1, $file, $ol,
+                      "no space after equals sign");
+        }
+        # check for equals sign without spaces before it
+        elsif($nostr =~ /(.*)[a-z0-9]\=/i) {
+            checkwarn("NOSPACEEQUALS",
+                      $line, length($1)+1, $file, $ol,
+                      "no space before equals sign");
+        }
+
         $line++;
         $prevl = $ol;
     }