From: Emeric Brun <ebrun@haproxy.com>
Date: Fri, 21 Aug 2015 09:48:54 +0000 (+0200)
Subject: BUG/MEDIUM: peers: fix wrong message id on stick table updates acknowledgement.
X-Git-Tag: v1.6-dev4~24
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e1ab808ff80d3382cd58cf4c0ffc2ef7f0e56fa8;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: peers: fix wrong message id on stick table updates acknowledgement.

The table definition message id was used instead of the update acknowledgement id.

This bug causes a malformated message and a protocol error and breaks the
connection.

After that, the updates remain unacknowledged.
---

diff --git a/src/peers.c b/src/peers.c
index 1f19fac5dc..b4f6b97924 100644
--- a/src/peers.c
+++ b/src/peers.c
@@ -429,7 +429,7 @@ static int peer_prepare_ackmsg(struct shared_table *st, char *msg, size_t size)
 
 	/*  prepare message header */
 	msg[0] = PEER_MSG_CLASS_STICKTABLE;
-	msg[1] = PEER_MSG_STKT_DEFINE;
+	msg[1] = PEER_MSG_STKT_ACK;
 	cursor = &msg[2];
 	intencode(datalen, &cursor);