From: William Lallemand <wlallemand@haproxy.org>
Date: Fri, 14 Jan 2022 13:08:34 +0000 (+0100)
Subject: BUG/MINOR: httpclient: don't send an empty body
X-Git-Tag: v2.6-dev1~130
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e1e045f4d71f85462414d048449c9307886f7c36;p=thirdparty%2Fhaproxy.git

BUG/MINOR: httpclient: don't send an empty body

Forbid the httpclient to send an empty chunked client when there is no
data to send. It does happen when doing a simple GET too.

Must be backported in 2.5.
---

diff --git a/src/http_client.c b/src/http_client.c
index 34e27c661a..2fb1b486fe 100644
--- a/src/http_client.c
+++ b/src/http_client.c
@@ -278,6 +278,10 @@ int httpclient_req_gen(struct httpclient *hc, const struct ist url, enum http_me
 	htx = htx_from_buf(&hc->req.buf);
 	if (!htx)
 		goto error;
+
+	if (!hc->ops.req_payload && !isttest(payload))
+		flags |= HTX_SL_F_BODYLESS;
+
 	sl = htx_add_stline(htx, HTX_BLK_REQ_SL, flags, meth_ist, url, vsn);
 	if (!sl) {
 		goto error;