From: William Lallemand <wlallemand@haproxy.com>
Date: Tue, 19 Nov 2024 15:39:55 +0000 (+0100)
Subject: MEDIUM: stats-file: silently ignore be/fe mistmatch
X-Git-Tag: v3.1-dev14~77
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e1fb9a47e11ab46b57bef2f064463a7b601c733e;p=thirdparty%2Fhaproxy.git

MEDIUM: stats-file: silently ignore be/fe mistmatch

Most of the invalid or unknow field in the stats-file parser are ignored
silently, which is not the case of the frontend/backend mismatch on a
guid, which is kind of strange.

Since this is ""documented"" to be ignored in the
reg-tests/stats/sample-stats-file file, let's also ignore this kind of
line. This will allow to run the associated reg-test with -dW.
---

diff --git a/src/stats-file.c b/src/stats-file.c
index cc1b636ce9..ae8e40fef1 100644
--- a/src/stats-file.c
+++ b/src/stats-file.c
@@ -279,13 +279,13 @@ static int parse_stat_line(struct ist line,
 
 		if (domain == STFILE_DOMAIN_PX_FE) {
 			if (!(px->cap & PR_CAP_FE))
-				goto err;
+				return 0; /* silently ignored fe/be mismatch */
 			base_off = (char *)&px->fe_counters;
 			off = 0;
 		}
 		else if (domain == STFILE_DOMAIN_PX_BE) {
 			if (!(px->cap & PR_CAP_BE))
-				goto err;
+				return 0; /* silently ignored fe/be mismatch */
 			base_off = (char *)&px->be_counters;
 			off = 1;
 		}