From: Cyril Bonté <cyril.bonte@free.fr>
Date: Fri, 4 Dec 2015 02:07:07 +0000 (+0100)
Subject: BUG/MINOR: checks: email-alert causes a segfault when an unknown mailers section... 
X-Git-Tag: v1.7-dev1~26
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e22bfd61b132601b3200121111c27d615f1122bf;p=thirdparty%2Fhaproxy.git

BUG/MINOR: checks: email-alert causes a segfault when an unknown mailers section is configured

A segfault can occur during at the initialization phase, when an unknown
"mailers" name is configured. This happens when "email-alert myhostname" is not
set, where a direct pointer to an array is used instead of copying the string,
causing the segfault when haproxy tries to free the memory.

This is a minor issue because the configuration is invalid and a fatal error
will remain, but it should be fixed to prevent reload issues.

Example of minimal configuration to reproduce the bug :
    backend example
        email-alert mailers NOT_FOUND
        email-alert from foo@localhost
        email-alert to bar@localhost

This fix must be backported to 1.6.
---

diff --git a/src/cfgparse.c b/src/cfgparse.c
index 9ebae2cfad..97f4243097 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -7470,7 +7470,7 @@ int check_config_validity()
 			    free_email_alert(curproxy);
 		    }
 		    if (!curproxy->email_alert.myhostname)
-			    curproxy->email_alert.myhostname = hostname;
+			    curproxy->email_alert.myhostname = strdup(hostname);
 		}
 
 		if (curproxy->check_command) {