From: Andrew Burgess <aburgess@redhat.com>
Date: Thu, 4 Dec 2025 15:18:02 +0000 (+0000)
Subject: gdb: remove some unnecessary code from print_gdb_hints
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e23075d2236101ab868b26f3f82bb9e9f39bff46;p=thirdparty%2Fbinutils-gdb.git

gdb: remove some unnecessary code from print_gdb_hints

I noticed some code in print_gdb_hints that is unused.  I rolled a
patch, but while I was doing that commit:

  commit 06e470d8fc0ae0e83fe0977fdf8c011998980891
  Date:   Sat Nov 29 15:48:55 2025 +0100

      gdb: handle unlimited screen width case in print_gdb_hints

was merged that deleted some of the code I'd spotted.  All that's left
is a 'return' that can be removed, there's nothing after the 'if'
block, the function just returns.

There should be no user visible changes after this commit.

Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
---

diff --git a/gdb/top.c b/gdb/top.c
index 52ec66b0607..f3cac5fd55a 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1446,8 +1446,6 @@ print_gdb_hints (struct ui_file *stream)
     {
       for (string_file &msg : styled_msg)
 	gdb_printf (stream, "%s\n", msg.c_str ());
-
-      return;
     }
   else
     {