From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 24 Oct 2016 19:27:30 +0000 (+0300)
Subject: doveadm director: Invalid parameters cause doveadm to fail silently.
X-Git-Tag: 2.2.27~295
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e235070817370d41159cbd5f14b2ca27720d48bf;p=thirdparty%2Fdovecot%2Fcore.git

doveadm director: Invalid parameters cause doveadm to fail silently.

doveadm_cmd_context.cmd doesn't point directly to doveadm_cmd_director.
---

diff --git a/src/doveadm/doveadm-director.c b/src/doveadm/doveadm-director.c
index 7725756082..25b0e399f9 100644
--- a/src/doveadm/doveadm-director.c
+++ b/src/doveadm/doveadm-director.c
@@ -992,9 +992,10 @@ static void director_cmd_help(const struct doveadm_cmd_ver2 *cmd)
 	unsigned int i;
 
 	for (i = 0; i < N_ELEMENTS(doveadm_cmd_director); i++) {
-		if (doveadm_cmd_director+i == cmd)
+		if (doveadm_cmd_director[i].cmd == cmd->cmd)
 			help_ver2(&doveadm_cmd_director[i]);
 	}
+	i_unreached();
 }
 
 void doveadm_register_director_commands(void)