From: W.C.A. Wijngaards <wouter@nlnetlabs.nl>
Date: Thu, 24 Jun 2021 20:57:12 +0000 (+0200)
Subject: Analysis workflow, remove debug output, strip more whitespace off
X-Git-Tag: release-1.13.2rc1~64
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e24c78efd64fbcbbd362756a0d54b0d610327c02;p=thirdparty%2Funbound.git

Analysis workflow, remove debug output, strip more whitespace off
ADDRESS lines in testbound range.
---

diff --git a/.github/workflows/analysis_ports.yml b/.github/workflows/analysis_ports.yml
index 5dafcfb7d..01169c90a 100644
--- a/.github/workflows/analysis_ports.yml
+++ b/.github/workflows/analysis_ports.yml
@@ -170,81 +170,6 @@ jobs:
         if: ${{ matrix.test_windows == 'yes' }}
         shell: bash
         run: |
-          echo 'c:'
-          ls -l 'c:\' || echo nevermind
-          echo 'Program Files'
-          ls -l 'c:\Program Files' || echo nevermind
-          echo 'Program Files (x86)'
-          ls -l 'c:\Program Files (x86)' || echo nevermind
-          echo '/c/Program Files/OpenSSL'
-          ls -l '/c/Program Files/OpenSSL' || echo nevermind
-          echo '/'
-          ls -l '/' || echo nevermind
-          echo '/mingw64'
-          ls -l '/mingw64' || echo nevermind
-          echo '/mingw64/bin'
-          ls -l '/mingw64/bin' || echo nevermind
-          echo '/c/Users'
-          ls -l '/c/Users' || echo nevermind
-          echo '/mingw64/ssl'
-          ls -l '/mingw64/ssl' || echo nevermind
-          echo '/c/ProgramData/Chocolatey'
-          ls -l '/c/ProgramData/Chocolatey' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/tools'
-          ls -l '/c/ProgramData/Chocolatey/tools' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib'
-          ls -l '/c/ProgramData/Chocolatey/lib' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/OpenSSL.Light'
-          ls -l '/c/ProgramData/Chocolatey/lib/OpenSSL.Light' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/OpenSSL.Light/tools'
-          ls -l '/c/ProgramData/Chocolatey/lib/OpenSSL.Light/tools' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/mingw'
-          ls -l '/c/ProgramData/Chocolatey/lib/mingw' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/mingw/tools'
-          ls -l '/c/ProgramData/Chocolatey/lib/mingw/tools' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/mingw/tools/install'
-          ls -l '/c/ProgramData/Chocolatey/lib/mingw/tools/install' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64'
-          ls -l '/c/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin'
-          ls -l '/c/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/bin' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/include'
-          ls -l '/c/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/include' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/rtools'
-          ls -l '/c/ProgramData/Chocolatey/lib/rtools' || echo nevermind
-          echo '/c/ProgramData/Chocolatey/lib/rtools/tools'
-          ls -l '/c/ProgramData/Chocolatey/lib/rtools/tools' || echo nevermind
-          echo '/c/Users/Default'
-          ls -l '/c/Users/Default' || echo nevermind
-          echo '/usr'
-          ls -l '/usr' || echo nevermind
-          echo '/usr/lib'
-          ls -l '/usr/lib' || echo nevermind
-          echo '/usr/share'
-          ls -l '/usr/share' || echo nevermind
-          echo '/c/Strawberry/perl'
-          ls -l '/c/Strawberry/perl' || echo nevermind
-          echo '/c/Strawberry/perl/bin'
-          ls -l '/c/Strawberry/perl/bin' || echo nevermind
-          echo '/c/Strawberry/perl/lib'
-          ls -l '/c/Strawberry/perl/lib' || echo nevermind
-          echo '/c/Strawberry/perl/site'
-          ls -l '/c/Strawberry/perl/site' || echo nevermind
-          echo '/c/Strawberry/perl/site/lib'
-          ls -l '/c/Strawberry/perl/site/lib' || echo nevermind
-          echo '/usr/lib/perl5'
-          ls -l '/usr/lib/perl5' || echo nevermind
-          echo '/usr/share/perl5'
-          ls -l '/usr/share/perl5' || echo nevermind
-          echo '/usr/share/perl5/vendor_perl'
-          ls -l '/usr/share/perl5/vendor_perl' || echo nevermind
-          echo '/usr/share/perl5/vendor_perl/Pod'
-          ls -l '/usr/share/perl5/vendor_perl/Pod' || echo nevermind
-          echo '/c/Program Files/Common Files'
-          ls -l '/c/Program Files/Common Files' || echo nevermind
-          echo '/c/Program Files/Common Files/SSL'
-          ls -l '/c/Program Files/Common Files/SSL' || echo nevermind
-          echo PATH="$PATH"
           export unboundpath=`pwd`
           echo unboundpath=${unboundpath}
           cd ..
@@ -253,19 +178,12 @@ jobs:
           #echo "curl cpanm"
           #curl -L -k -s -S -o cpanm https://cpanmin.us/
           #echo "perl cpanm Pod::Usage"
-          #perl cpanm Pod::Usage || echo whatever
+          #perl cpanm Pod::Usage
           mkdir openssl
           echo "curl openssl"
           curl -L -k -s -S -o openssl-1.1.1j.tar.gz https://www.openssl.org/source/openssl-1.1.1j.tar.gz
           tar xzf openssl-1.1.1j.tar.gz
           cd openssl-1.1.1j
-          #export PERL5LIB="/c/Strawberry/perl/lib"
-          #export PERL5LIB="/usr/share/perl5/lib:/usr/share/perl5/vendor:/usr/share/perl5/site"
-          #echo PERL5LIB="$PERL5LIB"
-          #echo "cpan"
-          #cpan POD::Usage
-          #echo "perl MCPAN"
-          #perl -MCPAN -e "CPAN::Shell->force(qw(install POD::Usage));"
           # remove pod::Usage because we do not need -help or -man output
           # from the Configure script
           sed -e 's/use Pod::Usage//' < Configure > Configure.fix
diff --git a/testcode/replay.c b/testcode/replay.c
index cbd22f9c7..18df4b7e7 100644
--- a/testcode/replay.c
+++ b/testcode/replay.c
@@ -375,8 +375,7 @@ replay_moment_read(char* remain, FILE* in, const char* name,
 	if(parse_keyword(&remain, "ADDRESS")) {
 		while(isspace((unsigned char)*remain))
 			remain++;
-		if(strlen(remain) > 0) /* remove \n */
-			remain[strlen(remain)-1] = 0;
+		strip_end_white(remain);
 		if(!extstrtoaddr(remain, &mom->addr, &mom->addrlen)) {
 			log_err("line %d: could not parse ADDRESS: %s", 
 				pstate->lineno, remain);