From: Thomas Huth Date: Mon, 22 Aug 2022 16:56:04 +0000 (+0100) Subject: tests/qtest/migration-test: Only wait for serial output where migration succeeds X-Git-Tag: v7.1.0-rc4~1^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e25636a12a1cc0a136aaa611a0cfbe6ebfa4aed4;p=thirdparty%2Fqemu.git tests/qtest/migration-test: Only wait for serial output where migration succeeds Waiting for the serial output can take a couple of seconds - and since we're doing a lot of migration tests, this time easily sums up to multiple minutes. But if a test is supposed to fail, it does not make much sense to wait for the source to be in the right state first, so we can skip the waiting here. This way we can speed up all tests where the migration is supposed to fail. In the gitlab-CI gprov-gcov test, each of the migration-tests now run two minutes faster! Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Thomas Huth Message-Id: <20220819053802.296584-2-thuth@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Juan Quintela Message-Id: <20220822165608.2980552-3-alex.bennee@linaro.org> --- diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 520a5f917ce..7be321b62de 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1307,7 +1307,9 @@ static void test_precopy_common(MigrateCommon *args) } /* Wait for the first serial output from the source */ - wait_for_serial("src_serial"); + if (args->result == MIG_TEST_SUCCEED) { + wait_for_serial("src_serial"); + } if (!args->connect_uri) { g_autofree char *local_connect_uri =