From: W.C.A. Wijngaards <wouter@nlnetlabs.nl>
Date: Wed, 9 Dec 2020 13:13:46 +0000 (+0100)
Subject: Fix use after free.
X-Git-Tag: release-1.13.2rc1~254^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e25f80799ad019d0625edac990ac4612aceac478;p=thirdparty%2Funbound.git

Fix use after free.
---

diff --git a/services/outside_network.c b/services/outside_network.c
index abc43e3c2..4315eaf1b 100644
--- a/services/outside_network.c
+++ b/services/outside_network.c
@@ -760,13 +760,16 @@ use_free_buffer(struct outside_network* outnet)
 				waiting_tcp_callback(w, NULL, NETEVENT_CLOSED,
 					NULL);
 				waiting_tcp_delete(w);
+#ifdef USE_DNSTAP
+				w = NULL;
+#endif
 			}
 #ifdef USE_DNSTAP
 			pend_tcp = pend;
 #endif
 		}
 #ifdef USE_DNSTAP
-		if(outnet->dtenv && pend_tcp && w->sq &&
+		if(outnet->dtenv && pend_tcp && w && w->sq &&
 		   (outnet->dtenv->log_resolver_query_messages ||
 		    outnet->dtenv->log_forwarder_query_messages)) {
 			sldns_buffer tmp;