From: Peter Griffin Date: Tue, 20 Feb 2024 11:50:12 +0000 (+0000) Subject: mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref X-Git-Tag: v6.9-rc1~120^2~15 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e28c28a34ee9fa2ea671a20e5e7064e6220d55e7;p=thirdparty%2Fkernel%2Flinux.git mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref of_parse_phandle() returns a device_node with refcount incremented, which the callee needs to call of_node_put() on when done. We should only call of_node_put() when the property argument is provided though as otherwise nothing has taken a reference on the node. Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager") Signed-off-by: Peter Griffin Link: https://lore.kernel.org/r/20240220115012.471689-4-peter.griffin@linaro.org Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index 0e52bd2ebd74b..fb5f988e61f37 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -109,7 +109,9 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, dev = driver_find_device_by_of_node(&altr_sysmgr_driver.driver, (void *)sysmgr_np); - of_node_put(sysmgr_np); + if (property) + of_node_put(sysmgr_np); + if (!dev) return ERR_PTR(-EPROBE_DEFER);