From: Stefan Weil <sw@weilnetz.de>
Date: Mon, 9 Sep 2024 20:42:54 +0000 (+0200)
Subject: Fix calculation of minimum in colo_compare_tcp
X-Git-Tag: v9.2.0-rc0~31^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e29bc931e1699a98959680f6776b48673825762b;p=thirdparty%2Fqemu.git

Fix calculation of minimum in colo_compare_tcp

GitHub's CodeQL reports a critical error which is fixed by using the MIN macro:

    Unsigned difference expression compared to zero

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Cc: qemu-stable@nongnu.org
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---

diff --git a/net/colo-compare.c b/net/colo-compare.c
index c4ad0ab71fa..39f90c40652 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -412,8 +412,7 @@ static void colo_compare_tcp(CompareState *s, Connection *conn)
      * can ensure that the packet's payload is acknowledged by
      * primary and secondary.
     */
-    uint32_t min_ack = conn->pack - conn->sack > 0 ?
-                       conn->sack : conn->pack;
+    uint32_t min_ack = MIN(conn->pack, conn->sack);
 
 pri:
     if (g_queue_is_empty(&conn->primary_list)) {