From: Onur Özkan <work@onurozkan.dev>
Date: Thu, 21 Aug 2025 09:07:20 +0000 (+0300)
Subject: rust: regulator: use `to_result` for error handling
X-Git-Tag: v6.18-rc1~166^2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e2ab5f600bb01d3625d667d97b3eb7538e388336;p=thirdparty%2Flinux.git

rust: regulator: use `to_result` for error handling

Simplifies error handling by replacing the manual check
of the return value with the `to_result` helper.

Signed-off-by: Onur Özkan <work@onurozkan.dev>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Message-ID: <20250821090720.23939-1-work@onurozkan.dev>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/rust/kernel/regulator.rs b/rust/kernel/regulator.rs
index 704147e18bfc9..34bb24ec8d4d4 100644
--- a/rust/kernel/regulator.rs
+++ b/rust/kernel/regulator.rs
@@ -267,11 +267,8 @@ impl<T: RegulatorState> Regulator<T> {
     pub fn get_voltage(&self) -> Result<Voltage> {
         // SAFETY: Safe as per the type invariants of `Regulator`.
         let voltage = unsafe { bindings::regulator_get_voltage(self.inner.as_ptr()) };
-        if voltage < 0 {
-            Err(kernel::error::Error::from_errno(voltage))
-        } else {
-            Ok(Voltage::from_microvolts(voltage))
-        }
+
+        to_result(voltage).map(|()| Voltage::from_microvolts(voltage))
     }
 
     fn get_internal(dev: &Device, name: &CStr) -> Result<Regulator<T>> {