From: drh <>
Date: Mon, 30 Jun 2025 11:04:55 +0000 (+0000)
Subject: Slightly smaller and faster version of the previous check-in.
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e2e81e69830bd25ff82bb8ac60d039a8e0efe971;p=thirdparty%2Fsqlite.git

Slightly smaller and faster version of the previous check-in.

FossilOrigin-Name: f6e6fd02f4ad49c390a2d3c9626d57f9b2fff1f67eb361b30074cc1f5121810e
---

diff --git a/manifest b/manifest
index e4cf97a0e0..e463cc2d0a 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Factor\sout\sthe\scode\sthat\stries\sto\savoid\sevaluating\ssubquery\soperands\sif\sthe\nother\soperand\sis\sNULL\sinto\sa\ssubroutine,\sso\sthat\sit\scan\sbe\smore\seasily\sreused\nby\sother\sparts\sof\sthe\scode\sgenerator.
-D 2025-06-30T10:30:47.908
+C Slightly\ssmaller\sand\sfaster\sversion\sof\sthe\sprevious\scheck-in.
+D 2025-06-30T11:04:55.886
 F .fossil-settings/binary-glob 61195414528fb3ea9693577e1980230d78a1f8b0a54c78cf1b9b24d0a409ed6a x
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
@@ -736,7 +736,7 @@ F src/date.c 9db4d604e699a73e10b8e85a44db074a1f04c0591a77e2abfd77703f50dce1e9
 F src/dbpage.c b3e218f8ed74fcbb7fa805df8ca669a3718d397617b3d8a8aac3307dc315c4d6
 F src/dbstat.c 73362c0df0f40ad5523a6f5501224959d0976757b511299bf892313e79d14f5c
 F src/delete.c 03a77ba20e54f0f42ebd8eddf15411ed6bdb06a2c472ac4b6b336521bf7cea42
-F src/expr.c f007ab177a9900d10893a58bf6b756e89144df635bab61b25f37a17390f12778
+F src/expr.c bfcf223fec3118214c2cc41c6aa520c716cb0e67a673258cd6fab3d143724c15
 F src/fault.c 460f3e55994363812d9d60844b2a6de88826e007
 F src/fkey.c 928ed2517e8732113d2b9821aa37af639688d752f4ea9ac6e0e393d713eeb76f
 F src/func.c de47a8295503aa130baae5e6d9868ecf4f7c4dbffa65d83ad1f70bdbac0ee2d6
@@ -2208,8 +2208,8 @@ F tool/version-info.c 3b36468a90faf1bbd59c65fd0eb66522d9f941eedd364fabccd7227350
 F tool/warnings-clang.sh bbf6a1e685e534c92ec2bfba5b1745f34fb6f0bc2a362850723a9ee87c1b31a7
 F tool/warnings.sh 1ad0169b022b280bcaaf94a7fa231591be96b514230ab5c98fbf15cd7df842dd
 F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f
-P f147bc04776ac0056412f69dfc518016c0d5b4e9d964664e3d88f595fb29dbe0
-R 2a36b21b6d3bc1bf7db15e8f66e788a3
+P 3c6c71bcea16443b82234414137dfa1b59e2ee8fe5097906c738fc1228fec4e6
+R 2d8283b273252189c8c03b9b869c5bf9
 U drh
-Z 4ecc3e0b30247a36c4e1fea0e6dc5b85
+Z f639db3f82a44bb4f9d7dfb2e1c4da9d
 # Remove this line to create a well-formed Fossil manifest.
diff --git a/manifest.uuid b/manifest.uuid
index 2be7100258..1d72a14d1a 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-3c6c71bcea16443b82234414137dfa1b59e2ee8fe5097906c738fc1228fec4e6
+f6e6fd02f4ad49c390a2d3c9626d57f9b2fff1f67eb361b30074cc1f5121810e
diff --git a/src/expr.c b/src/expr.c
index de729ea62f..a2df740af3 100644
--- a/src/expr.c
+++ b/src/expr.c
@@ -6137,20 +6137,12 @@ void sqlite3ExprIfFalse(Parse *pParse, Expr *pExpr, int dest, int jumpIfNull){
       break;
     }
     case TK_IS:
-    case TK_ISNOT: {
+    case TK_ISNOT:
       testcase( pExpr->op==TK_IS );
       testcase( pExpr->op==TK_ISNOT );
-      if( sqlite3ExprIsVector(pExpr->pLeft) ) goto default_expr;
       op = (pExpr->op==TK_IS) ? TK_NE : TK_EQ;
-      r1 = sqlite3ExprCodeTemp(pParse, pExpr->pLeft, &regFree1);
-      r2 = sqlite3ExprCodeTemp(pParse, pExpr->pRight, &regFree2);
-      codeCompare(pParse, pExpr->pLeft, pExpr->pRight, op,
-                  r1, r2, dest, SQLITE_NULLEQ,
-                  ExprHasProperty(pExpr,EP_Commuted));
-      testcase(op==OP_Eq); VdbeCoverageIf(v,op==OP_Eq);
-      testcase(op==OP_Ne); VdbeCoverageIf(v,op==OP_Ne);
-      break;
-    }
+      jumpIfNull = SQLITE_NULLEQ;
+      /* no break */ deliberate_fall_through
     case TK_LT:
     case TK_LE:
     case TK_GT:
@@ -6159,16 +6151,26 @@ void sqlite3ExprIfFalse(Parse *pParse, Expr *pExpr, int dest, int jumpIfNull){
     case TK_EQ: {
       int addrIsNull;
       if( sqlite3ExprIsVector(pExpr->pLeft) ) goto default_expr;
-      addrIsNull = exprComputeOperands(pParse, pExpr,
-                                 &r1, &r2, &regFree1, &regFree2);
+      if( ExprHasProperty(pExpr, EP_Subquery) && jumpIfNull!=SQLITE_NULLEQ ){
+        addrIsNull = exprComputeOperands(pParse, pExpr,
+                                   &r1, &r2, &regFree1, &regFree2);
+      }else{
+        r1 = sqlite3ExprCodeTemp(pParse, pExpr->pLeft, &regFree1);
+        r2 = sqlite3ExprCodeTemp(pParse, pExpr->pRight, &regFree2);
+        addrIsNull = 0;
+      }
       codeCompare(pParse, pExpr->pLeft, pExpr->pRight, op,
                   r1, r2, dest, jumpIfNull,ExprHasProperty(pExpr,EP_Commuted));
       assert(TK_LT==OP_Lt); testcase(op==OP_Lt); VdbeCoverageIf(v,op==OP_Lt);
       assert(TK_LE==OP_Le); testcase(op==OP_Le); VdbeCoverageIf(v,op==OP_Le);
       assert(TK_GT==OP_Gt); testcase(op==OP_Gt); VdbeCoverageIf(v,op==OP_Gt);
       assert(TK_GE==OP_Ge); testcase(op==OP_Ge); VdbeCoverageIf(v,op==OP_Ge);
-      assert(TK_EQ==OP_Eq); testcase(op==OP_Eq); VdbeCoverageIf(v,op==OP_Eq);
-      assert(TK_NE==OP_Ne); testcase(op==OP_Ne); VdbeCoverageIf(v,op==OP_Ne);
+      assert(TK_EQ==OP_Eq); testcase(op==OP_Eq);
+      VdbeCoverageIf(v, op==OP_Eq && jumpIfNull==SQLITE_NULLEQ);
+      VdbeCoverageIf(v, op==OP_Eq && jumpIfNull!=SQLITE_NULLEQ);
+      assert(TK_NE==OP_Ne); testcase(op==OP_Ne);
+      VdbeCoverageIf(v, op==OP_Ne && jumpIfNull==SQLITE_NULLEQ);
+      VdbeCoverageIf(v, op==OP_Ne && jumpIfNull!=SQLITE_NULLEQ);
       testcase( regFree1==0 );
       testcase( regFree2==0 );
       if( addrIsNull ){