From: Aníbal Limón Date: Thu, 27 Nov 2014 23:48:43 +0000 (-0600) Subject: fetch/wget: latest_versionstring clean improvments minor X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e30c11af7bc8a1f3d8c9198ee3c0065bd6b447cc;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git fetch/wget: latest_versionstring clean improvments minor Update documentation strings in _check_latest_dir and _check_latest_version methods with the correct return types. _check_latest_version method remove unused testversion variable. Signed-off-by: Aníbal Limón Signed-off-by: Richard Purdie --- diff --git a/lib/bb/fetch2/wget.py b/lib/bb/fetch2/wget.py index 7841553a86f..d82e78cb69d 100644 --- a/lib/bb/fetch2/wget.py +++ b/lib/bb/fetch2/wget.py @@ -192,7 +192,7 @@ class Wget(FetchMethod): def _check_latest_dir(self, url, versionstring, ud, d): """ Return the name of the directory with the greatest package version - If error or no version, return "" + If error or no version, return None """ bb.debug(3, "DirURL: %s, %s" % (url, versionstring)) soup = BeautifulSoup(self._fetch_index(url, ud, d)) @@ -230,7 +230,7 @@ class Wget(FetchMethod): def _check_latest_version(self, url, package, current_version, ud, d): """ Return the latest version of a package inside a given directory path - If error or no version, return "" + If error or no version, return None """ valid = 0 version = ('', '', '') @@ -243,7 +243,6 @@ class Wget(FetchMethod): pn_regex = d.getVar('REGEX', True) if pn_regex: - testversion = version pn_regex = re.compile(pn_regex) bb.debug(3, "pn_regex = '%s'" % (pn_regex.pattern))