From: mbellomi <massimiliano@scientiamobile.com>
Date: Tue, 21 May 2019 13:44:53 +0000 (+0200)
Subject: MINOR: WURFL: call header_retireve_callback() in dummy library
X-Git-Tag: v2.0-dev4~16
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e30e3001d92c32f24ac6fd3d3ebfb70405a577af;p=thirdparty%2Fhaproxy.git

MINOR: WURFL: call header_retireve_callback() in dummy library

The current coverage of the dummy library was limited because the callbacks
passed to wurfl_lookup() were not called. Now we do call them with one existing
and one non-existing headers to make sure that ha_wurfl_retrieve_header() is
covered by the tests as well.
---

diff --git a/contrib/wurfl/dummy-wurfl.c b/contrib/wurfl/dummy-wurfl.c
index c87d9b95b0..8c7909d121 100644
--- a/contrib/wurfl/dummy-wurfl.c
+++ b/contrib/wurfl/dummy-wurfl.c
@@ -67,6 +67,11 @@ wurfl_error wurfl_load(wurfl_handle hwurfl)
 
 wurfl_device_handle wurfl_lookup(wurfl_handle hwurfl, wurfl_header_retrieve_callback header_retrieve_callback, const void *header_retrieve_callback_data)
 {
+  // call callback, on a probably existing header
+  const char *hvalue = header_retrieve_callback("User-Agent", header_retrieve_callback_data);
+  // and on a non existing one
+  hvalue = header_retrieve_callback("Non-Existing-Header", header_retrieve_callback_data);
+
   return (void *) 0xdeffa;
 }