From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 14 Mar 2024 14:34:03 +0000 (+0100)
Subject: virsh: volume: Mark optional 'pool' argument as 'positional'
X-Git-Tag: v10.3.0-rc1~118
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e31cd4636436d8f49562d4168672893a1f6fa0ce;p=thirdparty%2Flibvirt.git

virsh: volume: Mark optional 'pool' argument as 'positional'

Annotate arguments which can be unintentionally parsed positionally.
(See previous commits for explanation.)

The pool name is optional but in all cases it can be promoted to an
optional positional argument so that it can be properly aligned with the
expectations of the parser.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index 8794126f21..7e6c6d5ef5 100644
--- a/tools/virsh-volume.c
+++ b/tools/virsh-volume.c
@@ -49,6 +49,7 @@
 #define VIRSH_COMMON_OPT_POOL_OPTIONAL \
     {.name = "pool", \
      .type = VSH_OT_STRING, \
+     .positional = true, \
      .help = N_("pool name or uuid"), \
      .completer = virshStoragePoolNameCompleter, \
      .completer_flags = VIR_CONNECT_LIST_STORAGE_POOLS_ACTIVE, \