From: Eugene Syromiatnikov <esyr@openssl.org>
Date: Mon, 15 Sep 2025 02:05:04 +0000 (+0200)
Subject: test/wpackettest.c: remove ubogus cleanup() in test_WPACKET_quic_vlint_random()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e321bc27c73bbd1ecb78d55cbdd5f58e795e5f1a;p=thirdparty%2Fopenssl.git

test/wpackettest.c: remove ubogus cleanup() in test_WPACKET_quic_vlint_random()

In the beginning of the iteration, pkt is not initialised yet, so there is
no need to clean it up on RAND_bytes() failure.  Replace "return cleanup(&pkt)"
with plain "return 0"'

Fixes: 416d0a638c16 "QUIC wire format support"
Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1665422
References: https://github.com/openssl/project/issues/1432
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28546)
---

diff --git a/test/wpackettest.c b/test/wpackettest.c
index bd696e00740..c6d6faf5c48 100644
--- a/test/wpackettest.c
+++ b/test/wpackettest.c
@@ -588,7 +588,7 @@ static int test_WPACKET_quic_vlint_random(void)
 
     for (i = 0; i < 10000; ++i) {
         if (!TEST_int_gt(RAND_bytes(rand_data, sizeof(rand_data)), 0))
-            return cleanup(&pkt);
+            return 0;
 
         memcpy(&expected, rand_data, sizeof(expected));