From: Noah Misch Date: Sat, 25 Mar 2023 20:00:27 +0000 (-0700) Subject: Comment on expectations for AutoVacuumWorkItem handlers. X-Git-Tag: REL_16_BETA1~427 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e33967b13bbc6e4e1c1b5e9ecd1c45148cffcc53;p=thirdparty%2Fpostgresql.git Comment on expectations for AutoVacuumWorkItem handlers. This might prevent a repeat of the brin_summarize_range() vulnerability that commit a117cebd638dd02e5c2e791c25e43745f233111b fixed. --- diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c index c0e2e00a7e3..585d28148ca 100644 --- a/src/backend/postmaster/autovacuum.c +++ b/src/backend/postmaster/autovacuum.c @@ -2655,7 +2655,10 @@ perform_work_item(AutoVacuumWorkItem *workitem) /* Use PortalContext for any per-work-item allocations */ MemoryContextSwitchTo(PortalContext); - /* have at it */ + /* + * Have at it. Functions called here are responsible for any required + * user switch and sandbox. + */ switch (workitem->avw_type) { case AVW_BRINSummarizeRange: