From: Yubo Feng Date: Wed, 12 Aug 2020 01:35:56 +0000 (-0700) Subject: fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes X-Git-Tag: v5.9-rc1~52^2~57 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e348e65a081d761caf72c2753c4e3d67bfb1ef80;p=thirdparty%2Fkernel%2Flinux.git fatfs: switch write_lock to read_lock in fat_ioctl_get_attributes There is no need to hold write_lock in fat_ioctl_get_attributes. write_lock may make an impact on concurrency of fat_ioctl_get_attributes. Signed-off-by: Yubo Feng Signed-off-by: Andrew Morton Acked-by: OGAWA Hirofumi Link: http://lkml.kernel.org/r/1593308053-12702-1-git-send-email-fengyubo3@huawei.com Signed-off-by: Linus Torvalds --- diff --git a/fs/fat/file.c b/fs/fat/file.c index 42134c58c87e1..f9ee27cf4d7c2 100644 --- a/fs/fat/file.c +++ b/fs/fat/file.c @@ -25,9 +25,9 @@ static int fat_ioctl_get_attributes(struct inode *inode, u32 __user *user_attr) { u32 attr; - inode_lock(inode); + inode_lock_shared(inode); attr = fat_make_attrs(inode); - inode_unlock(inode); + inode_unlock_shared(inode); return put_user(attr, user_attr); }