From: Michael R Sweet <michaelrsweet@gmail.com>
Date: Mon, 11 Apr 2016 22:36:42 +0000 (-0400)
Subject: Work around undocumented side-effect of SecItemAdd...
X-Git-Tag: v2.2b1~64
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e34d1ec4b926b3d31cfc00408faf99e69aa48ce8;p=thirdparty%2Fcups.git

Work around undocumented side-effect of SecItemAdd...
---

diff --git a/cups/tls-darwin.c b/cups/tls-darwin.c
index 91731438f1..0520294bde 100644
--- a/cups/tls-darwin.c
+++ b/cups/tls-darwin.c
@@ -161,7 +161,7 @@ cupsMakeServerCredentials(
     CFDictionaryRef itemAttrs = CFDictionaryCreate(kCFAllocatorDefault, itemKeys, itemValues, sizeof(itemKeys) / sizeof(itemKeys[0]), &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks);
 
     err = SecItemAdd(itemAttrs, NULL);
-    CFRelease(itemAttrs);
+    /* SecItemAdd consumes itemAttrs... */
 
     if (err != noErr)
       goto cleanup;