From: Willy Tarreau <w@1wt.eu>
Date: Fri, 15 Jun 2012 06:02:34 +0000 (+0200)
Subject: BUG/MINOR: ACL implicit arguments must be created with unresolved flag
X-Git-Tag: v1.5-dev12~140
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e3a461118c8dda526787fc01df50bc3a897f5705;p=thirdparty%2Fhaproxy.git

BUG/MINOR: ACL implicit arguments must be created with unresolved flag

Commit 496aa0 fixed a design issue by adding an "unresolved" flag to the
ACL arguments. Unfortunately this unresolved flag was not set when building
the fake argument some ACL need when using an implicit argument pointing to
the local proxy.

Special thanks to Michael Kearey who reported the issue with a reproducer
and the commit introducing the bug.
---

diff --git a/src/acl.c b/src/acl.c
index e51dafc9de..e2e72ceb6a 100644
--- a/src/acl.c
+++ b/src/acl.c
@@ -1422,6 +1422,7 @@ struct acl_expr *parse_acl_expr(const char **args, char **err)
 			 */
 			expr->args = calloc(2, sizeof(*expr->args));
 			expr->args[0].type = type;
+			expr->args[0].unresolved = 1;
 			expr->args[0].data.str.str = strdup("");
 			expr->args[0].data.str.len = 1;
 			expr->args[0].data.str.len = 0;