From: Miod Vallat <miod.vallat@powerdns.com>
Date: Mon, 30 Jun 2025 06:58:06 +0000 (+0200)
Subject: Rewrite some for(;;) loops as while loops. NFC
X-Git-Tag: rec-5.3.0-alpha2~29^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e40764ebc90493de4f55f76fb65a36bb5881030e;p=thirdparty%2Fpdns.git

Rewrite some for(;;) loops as while loops. NFC

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 2415554bc6..bc8908f88f 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -2383,11 +2383,7 @@ bool LMDBBackend::getBeforeAndAfterNamesAbsolute(domainid_t id, const DNSName& q
       // cout<<"hit end of zone find when we shouldn't"<<endl;
       return false;
     }
-    for (;;) {
-      if (isNSEC3BackRecord(lrr, key, val)) {
-        break;
-      }
-
+    while (!isNSEC3BackRecord(lrr, key, val)) {
       if (cursor.next(key, val) || co.getDomainID(key.getNoStripHeader<StringView>()) != id) {
         // cout<<"hit end of zone or database when we shouldn't"<<endl;
         return false;
@@ -2412,11 +2408,7 @@ bool LMDBBackend::getBeforeAndAfterNamesAbsolute(domainid_t id, const DNSName& q
         // cout<<"hit end of zone find when we shouldn't for id "<<id<< __LINE__<<endl;
         return false;
       }
-      for (;;) {
-        if (isNSEC3BackRecord(lrr, key, val)) {
-          break;
-        }
-
+      while (!isNSEC3BackRecord(lrr, key, val)) {
         if (cursor.next(key, val) || co.getDomainID(key.getNoStripHeader<StringView>()) != id) {
           // cout<<"hit end of zone or database when we shouldn't" << __LINE__<<endl;
           return false;
@@ -2474,11 +2466,7 @@ bool LMDBBackend::getBeforeAndAfterNamesAbsolute(domainid_t id, const DNSName& q
           // means database is wrong, nothing we can do
           return false;
         }
-        for (;;) {
-          if (isNSEC3BackRecord(lrr, key, val)) {
-            break;
-          }
-
+        while (!isNSEC3BackRecord(lrr, key, val)) {
           if (cursor.next(key, val)) {
             // means database is wrong, nothing we can do
             // cout<<"hit end of zone when we shouldn't 2"<<endl;
@@ -2508,11 +2496,7 @@ bool LMDBBackend::getBeforeAndAfterNamesAbsolute(domainid_t id, const DNSName& q
         // means database is wrong, nothing we can do
         return false;
       }
-      for (;;) {
-        if (isNSEC3BackRecord(lrr, key, val)) {
-          break;
-        }
-
+      while (!isNSEC3BackRecord(lrr, key, val)) {
         if (cursor.next(key, val)) {
           // means database is wrong, nothing we can do
           // cout<<"hit end of zone when we shouldn't 2"<<endl;