From: René Scharfe <l.s.r@web.de>
Date: Sat, 28 Dec 2024 09:48:50 +0000 (+0100)
Subject: reftable: handle realloc error in parse_names()
X-Git-Tag: v2.48.0-rc2~10^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e4981ed1e72d3f25da901b9415d2c4805bed0dbc;p=thirdparty%2Fgit.git

reftable: handle realloc error in parse_names()

Check the final reallocation for adding the terminating NULL and handle
it just like those in the loop.  Simply use REFTABLE_ALLOC_GROW instead
of keeping the REFTABLE_REALLOC_ARRAY call and adding code to preserve
the original pointer value around it.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/reftable/basics.c b/reftable/basics.c
index cd6b39dbe9..fe2b83ff83 100644
--- a/reftable/basics.c
+++ b/reftable/basics.c
@@ -241,7 +241,8 @@ char **parse_names(char *buf, int size)
 		p = next + 1;
 	}
 
-	REFTABLE_REALLOC_ARRAY(names, names_len + 1);
+	if (REFTABLE_ALLOC_GROW(names, names_len + 1, names_cap))
+		goto err;
 	names[names_len] = NULL;
 
 	return names;