From: Jakub Kicinski Date: Wed, 7 Nov 2018 01:07:30 +0000 (-0800) Subject: nfp: flower: remove unnecessary iteration over devices X-Git-Tag: v5.0-rc1~129^2~382^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e50bfdf74d5f81c81f7a00498aa7fd1cba53b65b;p=thirdparty%2Flinux.git nfp: flower: remove unnecessary iteration over devices For flower tunnel offloads FW has to be informed about MAC addresses of tunnel devices. We use a netdev notifier to keep track of these addresses. Remove unnecessary loop over netdevices after notifier is registered. The intention of the loop was to catch devices which already existed on the system before nfp driver got loaded, but netdev notifier will replay NETDEV_REGISTER events. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c index 8e5bec04d1f97..a3a44f1187d30 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c +++ b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c @@ -686,7 +686,6 @@ static int nfp_tun_mac_event_handler(struct notifier_block *nb, int nfp_tunnel_config_start(struct nfp_app *app) { struct nfp_flower_priv *priv = app->priv; - struct net_device *netdev; int err; /* Initialise priv data for MAC offloading. */ @@ -715,12 +714,6 @@ int nfp_tunnel_config_start(struct nfp_app *app) if (err) goto err_unreg_mac_nb; - /* Parse netdevs already registered for MACs that need offloaded. */ - rtnl_lock(); - for_each_netdev(&init_net, netdev) - nfp_tun_add_to_mac_offload_list(netdev, app); - rtnl_unlock(); - return 0; err_unreg_mac_nb: