From: Aki Tuomi <aki.tuomi@dovecot.fi>
Date: Tue, 6 Sep 2016 13:02:26 +0000 (+0300)
Subject: lib-dict: Discard result when callback is NULL on async call
X-Git-Tag: 2.2.26~304
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e525e4215127aeb76a3b5a31f1a0d24a68f37c68;p=thirdparty%2Fdovecot%2Fcore.git

lib-dict: Discard result when callback is NULL on async call
---

diff --git a/src/lib-dict/dict-client.c b/src/lib-dict/dict-client.c
index 5a8f7e347f..9fa365cd64 100644
--- a/src/lib-dict/dict-client.c
+++ b/src/lib-dict/dict-client.c
@@ -1073,8 +1073,10 @@ client_dict_transaction_commit_callback(struct client_dict_cmd *cmd,
 
 static void commit_sync_callback(int ret, void *context)
 {
-	int *ret_p = context;
-	*ret_p = ret;
+	if (context != NULL) {
+		int *ret_p = context;
+		*ret_p = ret;
+	}
 }
 
 static int
@@ -1103,7 +1105,7 @@ client_dict_transaction_commit(struct dict_transaction_context *_ctx,
 			cmd->api_callback.context = context;
 		} else {
 			cmd->api_callback.commit = commit_sync_callback;
-			cmd->api_callback.context = &ret;
+			cmd->api_callback.context = (async ? NULL : &ret);
 			if (async)
 				cmd->background = TRUE;
 		}