From: Eric Sunshine Date: Thu, 9 Dec 2021 05:11:01 +0000 (-0500) Subject: t5516: drop unnecessary subshell and command invocation X-Git-Tag: v2.35.0-rc0~46^2~14 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e57ea501d00eab6191993f35e502aface5ceac5e;p=thirdparty%2Fgit.git t5516: drop unnecessary subshell and command invocation To create its "expect" file, this test pipes into `sort` the output of `git for-each-ref` and a copy of that same output but with a minor textual transformation applied. To do so, it employs a subshell and commands `cat` and `sed` even though the same result can be accomplished by `sed` alone (without a subshell). Signed-off-by: Eric Sunshine Reviewed-by: Elijah Newren Signed-off-by: Junio C Hamano --- diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh index 8212ca56dc..d5e19b54af 100755 --- a/t/t5516-fetch-push.sh +++ b/t/t5516-fetch-push.sh @@ -1316,10 +1316,7 @@ test_expect_success 'fetch follows tags by default' ' git pull ../testrepo main && git tag -m "annotated" tag && git for-each-ref >tmp1 && - ( - cat tmp1 - sed -n "s|refs/heads/main$|refs/remotes/origin/main|p" tmp1 - ) | + sed -n "p; s|refs/heads/main$|refs/remotes/origin/main|p" tmp1 | sort -k 3 >../expect ) && git init dst &&