From: Dan Carpenter Date: Wed, 21 Apr 2021 10:18:03 +0000 (+0300) Subject: drm/vc4: fix argument ordering in vc4_crtc_get_margins() X-Git-Tag: v5.14-rc1~114^2~25^2~95 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e590c2b03a6143ba93ddad306bc9eaafa838c020;p=thirdparty%2Fkernel%2Flinux.git drm/vc4: fix argument ordering in vc4_crtc_get_margins() Cppcheck complains that the declaration doesn't match the function definition. Obviously "left" should come before "right". The caller and the function implementation are done this way, it's just the declaration which is wrong so this doesn't affect runtime. Reported-by: kernel test robot Signed-off-by: Dan Carpenter Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/YH/720FD978TPhHp@mwanda --- diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index a7500716cf3f1..5dceadc61600e 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.h +++ b/drivers/gpu/drm/vc4/vc4_drv.h @@ -825,7 +825,7 @@ void vc4_crtc_destroy_state(struct drm_crtc *crtc, void vc4_crtc_reset(struct drm_crtc *crtc); void vc4_crtc_handle_vblank(struct vc4_crtc *crtc); void vc4_crtc_get_margins(struct drm_crtc_state *state, - unsigned int *right, unsigned int *left, + unsigned int *left, unsigned int *right, unsigned int *top, unsigned int *bottom); /* vc4_debugfs.c */