From: Sudip Mukherjee Date: Fri, 16 Apr 2021 23:53:36 +0000 (+0100) Subject: media: sp887x: drop unneeded assignment X-Git-Tag: v5.17-rc1~171^2~208 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e594cda5f8c8e34ac6444166418690c65bbda47f;p=thirdparty%2Fkernel%2Flinux.git media: sp887x: drop unneeded assignment The pointer 'mem' was initialized to 'fw->data' but immediately after that it was assigned 'fw->data + 10'. Lets remove the extra assignement and initialize the pointer to the address its going to use. Link: https://lore.kernel.org/linux-media/20210416235336.1552102-1-sudipm.mukherjee@gmail.com Cc: Sudip Mukherjee Signed-off-by: Sudip Mukherjee Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-frontends/sp887x.c b/drivers/media/dvb-frontends/sp887x.c index c89a91a3daf40..146e7f2dd3c5e 100644 --- a/drivers/media/dvb-frontends/sp887x.c +++ b/drivers/media/dvb-frontends/sp887x.c @@ -140,7 +140,7 @@ static int sp887x_initial_setup (struct dvb_frontend* fe, const struct firmware u8 buf [BLOCKSIZE + 2]; int i; int fw_size = fw->size; - const unsigned char *mem = fw->data; + const unsigned char *mem = fw->data + 10; dprintk("%s\n", __func__); @@ -148,8 +148,6 @@ static int sp887x_initial_setup (struct dvb_frontend* fe, const struct firmware if (fw_size < FW_SIZE + 10) return -ENODEV; - mem = fw->data + 10; - /* soft reset */ sp887x_writereg(state, 0xf1a, 0x000);