From: Marc-André Lureau Date: Wed, 20 Apr 2022 13:25:56 +0000 (+0400) Subject: arm/digic: replace snprintf() with g_strdup_printf() X-Git-Tag: v7.1.0-rc0~140^2~22 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e5c41835250ebb3f0297606bc7cc48cfa5474e8f;p=thirdparty%2Fqemu.git arm/digic: replace snprintf() with g_strdup_printf() Also fixes a GCC 12.0.1 false-positive: ../hw/arm/digic.c: In function ‘digic_init’: ../hw/arm/digic.c:45:54: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 5 [-Werror=format-truncation=] 45 | snprintf(name, DIGIC_TIMER_NAME_MLEN, "timer[%d]", i); | ^~ Signed-off-by: Marc-André Lureau Reviewed-by: Peter Maydell Reviewed-by: Daniel P. Berrangé Message-Id: <20220420132624.2439741-14-marcandre.lureau@redhat.com> --- diff --git a/hw/arm/digic.c b/hw/arm/digic.c index 614232165cd..6df55479773 100644 --- a/hw/arm/digic.c +++ b/hw/arm/digic.c @@ -39,10 +39,7 @@ static void digic_init(Object *obj) object_initialize_child(obj, "cpu", &s->cpu, ARM_CPU_TYPE_NAME("arm946")); for (i = 0; i < DIGIC4_NB_TIMERS; i++) { -#define DIGIC_TIMER_NAME_MLEN 11 - char name[DIGIC_TIMER_NAME_MLEN]; - - snprintf(name, DIGIC_TIMER_NAME_MLEN, "timer[%d]", i); + g_autofree char *name = g_strdup_printf("timer[%d]", i); object_initialize_child(obj, name, &s->timer[i], TYPE_DIGIC_TIMER); }