From: Daniel Gabay <daniel.gabay@intel.com>
Date: Tue, 8 Oct 2024 04:25:22 +0000 (+0300)
Subject: wifi: iwlwifi: mvm: Remove redundant rcu_read_lock() in reorder buffer
X-Git-Tag: v6.13-rc1~135^2~195^2~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e5c6c41522201f0a58c61c6528f56afdfdb232e2;p=thirdparty%2Fkernel%2Flinux.git

wifi: iwlwifi: mvm: Remove redundant rcu_read_lock() in reorder buffer

iwl_mvm_reorder() is already called within a rcu-read section.

Signed-off-by: Daniel Gabay <daniel.gabay@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241008072037.8f229e1b08b7.I31a371f635d84db300ad16ce6170cc07a8b154fb@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
index fdbd63ff91ef1..a2f16bfaec441 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
@@ -773,9 +773,7 @@ static bool iwl_mvm_reorder(struct iwl_mvm *mvm,
 		return false;
 	}
 
-	rcu_read_lock();
 	sta_mask = iwl_mvm_sta_fw_id_mask(mvm, sta, -1);
-	rcu_read_unlock();
 
 	if (IWL_FW_CHECK(mvm,
 			 tid != baid_data->tid ||