From: Pauli <paul.dale@oracle.com>
Date: Thu, 21 May 2020 03:38:35 +0000 (+1000)
Subject: Coverity 1463576: Error handling issues (CHECKED_RETURN)
X-Git-Tag: openssl-3.0.0-alpha3~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e5cb3453fba01c264636d54440ca0eb81d1fcd6e;p=thirdparty%2Fopenssl.git

Coverity 1463576: Error handling issues (CHECKED_RETURN)

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/11892)
---

diff --git a/providers/implementations/serializers/serializer_rsa.c b/providers/implementations/serializers/serializer_rsa.c
index ac685a09f2b..7cc6027636c 100644
--- a/providers/implementations/serializers/serializer_rsa.c
+++ b/providers/implementations/serializers/serializer_rsa.c
@@ -215,9 +215,9 @@ int ossl_prov_prepare_rsa_params(const void *rsa, int nid,
                     break;
                 }
                 if (!DER_w_RSASSA_PSS_params(&pkt, -1, pss)
-                    || !WPACKET_finish(&pkt))
+                    || !WPACKET_finish(&pkt)
+                    || !WPACKET_get_total_written(&pkt, &str_sz))
                     goto err;
-                WPACKET_get_total_written(&pkt, &str_sz);
                 WPACKET_cleanup(&pkt);
 
                 /*