From: Lidong Yan <502024330056@smail.nju.edu.cn>
Date: Mon, 12 May 2025 02:07:27 +0000 (+0000)
Subject: builtin/am: fix memory leak in `split_mail_stgit_series`
X-Git-Tag: v2.50.0-rc0~31^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e5dd0a05ed392bc0c2dde84a1ee1d6eaeaac357f;p=thirdparty%2Fgit.git

builtin/am: fix memory leak in `split_mail_stgit_series`

In builtin/am.c:split_mail_stgit_series, if `fopen` failed,
`series_dir_buf` allocated by `xstrdup` will leak. Add `free` in
`!fp` if branch will prevent the leak.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/am.c b/builtin/am.c
index d1990d7edc..bb36b42aa1 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -848,8 +848,10 @@ static int split_mail_stgit_series(struct am_state *state, const char **paths,
 	series_dir = dirname(series_dir_buf);
 
 	fp = fopen(*paths, "r");
-	if (!fp)
+	if (!fp) {
+		free(series_dir_buf);
 		return error_errno(_("could not open '%s' for reading"), *paths);
+	}
 
 	while (!strbuf_getline_lf(&sb, fp)) {
 		if (*sb.buf == '#')