From: Dan Carpenter Date: Wed, 12 Feb 2025 15:24:09 +0000 (+0300) Subject: drm/tests: Fix a test in drm_test_check_valid_clones() X-Git-Tag: v6.15-rc1~120^2~19^2~60 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e5f5f7ccae5fd5807587f8075e06eb8a9fca2b41;p=thirdparty%2Fkernel%2Flinux.git drm/tests: Fix a test in drm_test_check_valid_clones() The drm_atomic_get_crtc_state() function returns error pointers and not NULL. Update the check to check for error pointers as well as NULL. Fixes: 88849f24e2ab ("drm/tests: Add test for drm_atomic_helper_check_modeset()") Signed-off-by: Dan Carpenter Link: https://patchwork.freedesktop.org/patch/msgid/c50f11c7-932c-47dc-b40f-4ada8b9b6679@stanley.mountain Signed-off-by: Maxime Ripard --- diff --git a/drivers/gpu/drm/tests/drm_atomic_state_test.c b/drivers/gpu/drm/tests/drm_atomic_state_test.c index 0ab5d9ec4a750..5945c32989011 100644 --- a/drivers/gpu/drm/tests/drm_atomic_state_test.c +++ b/drivers/gpu/drm/tests/drm_atomic_state_test.c @@ -283,7 +283,7 @@ static void drm_test_check_valid_clones(struct kunit *test) KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state); crtc_state = drm_atomic_get_crtc_state(state, priv->crtc); - KUNIT_ASSERT_NOT_NULL(test, crtc_state); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state); crtc_state->encoder_mask = param->encoder_mask;