From: Bruno Haible <bruno@clisp.org>
Date: Thu, 3 Oct 2024 11:25:29 +0000 (+0200)
Subject: hurd: Add missing va_end call in fcntl implementation. [BZ #32234]
X-Git-Tag: glibc-2.41~604
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e67f8e6dbd5ec98578a775b2e09b254f071e0f57;p=thirdparty%2Fglibc.git

hurd: Add missing va_end call in fcntl implementation. [BZ #32234]

* sysdeps/mach/hurd/fcntl.c (__libc_fcntl): Add va_end call in two code paths.
---

diff --git a/sysdeps/mach/hurd/fcntl.c b/sysdeps/mach/hurd/fcntl.c
index 9451ed5649..2583f54ef2 100644
--- a/sysdeps/mach/hurd/fcntl.c
+++ b/sysdeps/mach/hurd/fcntl.c
@@ -148,6 +148,7 @@ __libc_fcntl (int fd, int cmd, ...)
 	    cmd = F_SETLKW64;
 	    break;
 	  default:
+	    va_end (ap);
 	    return __hurd_fail (EINVAL);
 	  }
 
@@ -204,7 +205,10 @@ __libc_fcntl (int fd, int cmd, ...)
 		 && fl->l_start != fl64.l_start)
 	     || (sizeof fl->l_len != sizeof fl64.l_len
 		 && fl->l_len != fl64.l_len))
-	      return __hurd_fail (EOVERFLOW);
+	      {
+	        va_end (ap);
+	        return __hurd_fail (EOVERFLOW);
+	      }
 	  }
 
 	result = err ? __hurd_dfail (fd, err) : 0;