From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 25 Nov 2019 11:19:55 +0000 (+0200)
Subject: fs-posix: Replace fs_set_critical() with e_error()
X-Git-Tag: 2.3.10~216
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e743151cfcf697bee259f93c939312526580af85;p=thirdparty%2Fdovecot%2Fcore.git

fs-posix: Replace fs_set_critical() with e_error()

fs_set_error() can't be used in fs_file_close() and fs_file_deinit(),
because they don't return an error.
---

diff --git a/src/lib-fs/fs-posix.c b/src/lib-fs/fs-posix.c
index f9437f3b7c..ae4cdca4cd 100644
--- a/src/lib-fs/fs-posix.c
+++ b/src/lib-fs/fs-posix.c
@@ -353,8 +353,8 @@ static void fs_posix_file_close(struct fs_file *_file)
 
 	if (file->fd != -1 && file->file.output == NULL) {
 		if (close(file->fd) < 0) {
-			fs_set_critical(file->file.fs, "close(%s) failed: %m",
-					file->full_path);
+			e_error(_file->event, "close(%s) failed: %m",
+				file->full_path);
 		}
 		file->fd = -1;
 	}
@@ -378,8 +378,8 @@ static void fs_posix_file_deinit(struct fs_file *_file)
 			break;
 		/* failed to create/replace this. delete the temp file */
 		if (unlink(file->temp_path) < 0) {
-			fs_set_critical(_file->fs, "unlink(%s) failed: %m",
-					file->temp_path);
+			e_error(_file->event, "unlink(%s) failed: %m",
+				file->temp_path);
 		}
 		break;
 	}