From: Greg Kurz <groug@kaod.org>
Date: Wed, 2 Aug 2017 17:34:16 +0000 (+0200)
Subject: ppc: fix double-free in cpu_post_load()
X-Git-Tag: v2.10.0-rc3~18^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e7bab9a256d653948760ef9f3d04f14eb2a81731;p=thirdparty%2Fqemu.git

ppc: fix double-free in cpu_post_load()

When running nested with KVM PR, ppc_set_compat() fails and QEMU crashes
because of "double free or corruption (!prev)". The crash happens because
error_report_err() has already called error_free().

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---

diff --git a/target/ppc/machine.c b/target/ppc/machine.c
index f578156dd41..abe0a1cdf02 100644
--- a/target/ppc/machine.c
+++ b/target/ppc/machine.c
@@ -239,7 +239,6 @@ static int cpu_post_load(void *opaque, int version_id)
         ppc_set_compat(cpu, cpu->compat_pvr, &local_err);
         if (local_err) {
             error_report_err(local_err);
-            error_free(local_err);
             return -1;
         }
     } else