From: Shree Ramamoorthy Date: Tue, 17 Dec 2024 20:45:23 +0000 (-0600) Subject: regulator: tps65219: Use dev_err_probe() instead of dev_err() X-Git-Tag: v6.14-rc1~158^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e7ce0437709552a5f5e577c29f3dfde620153913;p=thirdparty%2Fkernel%2Flinux.git regulator: tps65219: Use dev_err_probe() instead of dev_err() Make the error message format unified by switching from dev_err() to dev_err_probe() where there is a chance of -EPROBE_DEFER returned. This helps simplify the error code where possible. Signed-off-by: Shree Ramamoorthy Link: https://patch.msgid.link/20241217204526.1010989-2-s-ramamoorthy@ti.com Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index b4065356392f0..14d843a99d0fe 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -322,11 +322,11 @@ static int tps65219_regulator_probe(struct platform_device *pdev) dev_dbg(tps->dev, "%s regul i= %d START", __func__, i); rdev = devm_regulator_register(&pdev->dev, ®ulators[i], &config); - if (IS_ERR(rdev)) { - dev_err(tps->dev, "failed to register %s regulator\n", - regulators[i].name); - return PTR_ERR(rdev); - } + if (IS_ERR(rdev)) + return dev_err_probe(tps->dev, PTR_ERR(rdev), + "Failed to register %s regulator\n", + regulators[i].name); + rdevtbl[i] = rdev; dev_dbg(tps->dev, "%s regul i= %d COMPLETED", __func__, i); }