From: lan1120 <lanming@huawei.com>
Date: Fri, 19 Sep 2025 10:45:30 +0000 (+0800)
Subject: Fix the abnormal branch memory leak in ssl_set_cert_and_key function
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e7f88391867dd71dc0ef37646f497411bea5350c;p=thirdparty%2Fopenssl.git

Fix the abnormal branch memory leak in ssl_set_cert_and_key function

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28619)
---

diff --git a/ssl/ssl_rsa.c b/ssl/ssl_rsa.c
index a1ea7ed105d..d2b7b171c87 100644
--- a/ssl/ssl_rsa.c
+++ b/ssl/ssl_rsa.c
@@ -1056,10 +1056,13 @@ static int ssl_set_cert_and_key(SSL *ssl, SSL_CTX *ctx, X509 *x509, EVP_PKEY *pr
         }
     }
 
-    if (!X509_up_ref(x509))
+    if (!X509_up_ref(x509)) {
+        OSSL_STACK_OF_X509_free(dup_chain);
         goto out;
+    }
 
     if (!EVP_PKEY_up_ref(privatekey)) {
+        OSSL_STACK_OF_X509_free(dup_chain);
         X509_free(x509);
         goto out;
     }