From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Thu, 11 Mar 2021 16:06:30 +0000 (+0100)
Subject: BUG/MINOR: quic: Wrong ->accept() error handling
X-Git-Tag: v2.5-dev8~144
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e8139f3b378568c065da1a082db73352da64b289;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Wrong ->accept() error handling

Really signal the caller that ->accept() has failed if the session could not
be initialized because conn_complete_session() has failed. This is the case
if the mux could not be initialized too.
When it fails an ->accept() must returns -1 in case of resource shortage.
---

diff --git a/src/quic_sock.c b/src/quic_sock.c
index 1a5cf69df2..011b93ad6d 100644
--- a/src/quic_sock.c
+++ b/src/quic_sock.c
@@ -69,8 +69,6 @@ int quic_session_accept(struct connection *cli_conn)
 	if (conn_complete_session(cli_conn) >= 0)
 		return 1;
 
-	return 0;
-
  out_free_sess:
 	/* prevent call to listener_release during session_free. It will be
 	* done below, for all errors. */
@@ -83,7 +81,7 @@ int quic_session_accept(struct connection *cli_conn)
 	conn_free(cli_conn);
  out:
 
-	return 0;
+	return -1;
 }
 
 /*