From: Aaron Merey <amerey@redhat.com>
Date: Mon, 8 Sep 2025 02:17:29 +0000 (-0400)
Subject: readelf.c: Close dwfl if dwfl_report_offline fails
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e833b1778754fc598ef867a3c3623187fb165510;p=thirdparty%2Felfutils.git

readelf.c: Close dwfl if dwfl_report_offline fails

Within create_dwfl, if dwfl_begin is successful but dwfl_report_offline
fails, the dwfl * pointer being reported is reset to NULL without calling
dwfl_end, causing a memory leak.

Update create_dwfl to call dwfl_end in this case, preventing the leak.

Signed-off-by: Aaron Merey <amerey@redhat.com>
---

diff --git a/src/readelf.c b/src/readelf.c
index 6b886c59..138ded6b 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -978,6 +978,7 @@ create_dwfl (int fd, const char *fname)
 	error (0, 0, _("failed reading '%s': %s"),
 	       fname, dwfl_errmsg (-1));
       close (dwfl_fd);		/* Consumed on success, not on failure.  */
+      dwfl_end (dwfl);
       dwfl = NULL;
     }
   else