From: Thierry FOURNIER <tfournier@exceliance.fr>
Date: Mon, 9 Mar 2015 16:10:29 +0000 (+0100)
Subject: BUG/MINOR: log: segfault if there are no proxy reference
X-Git-Tag: v1.6-dev1~51
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e83766afd1c5fc77f74698183fe174907cbc323f;p=thirdparty%2Fhaproxy.git

BUG/MINOR: log: segfault if there are no proxy reference

The HAProxy API allow to send log without defined proxy (it
set to the NULL value). An incomplete test if done to choose
the log tag and an invalid pointer is dereferenced.
---

diff --git a/src/log.c b/src/log.c
index 6c01248e39..f7d160dcfd 100644
--- a/src/log.c
+++ b/src/log.c
@@ -775,7 +775,7 @@ void send_log(struct proxy *p, int level, const char *format, ...)
 	if (level < 0 || format == NULL || logline == NULL)
 		return;
 
-	dataptr = update_log_hdr(p->log_tag ? p->log_tag : global.log_tag); /* update log header and skip it */
+	dataptr = update_log_hdr(p && p->log_tag ? p->log_tag : global.log_tag); /* update log header and skip it */
 	data_len = dataptr - logline;
 
 	va_start(argp, format);