From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 17 Mar 2025 15:26:35 +0000 (+0100)
Subject: BUG/MINOR: mux-h2: Reset streams with NO_ERROR code if full response was already... 
X-Git-Tag: v3.2-dev8~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e87397bc7d3b386c95d1489d19f29e6d5f1f1482;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mux-h2: Reset streams with NO_ERROR code if full response was already sent

On frontend side, when a stream is shut while the response was already fully
sent, it was cancelled by sending a RST_STREAM(CANCEL) frame. However, it is
not accurrate. CANCEL error code must only be used if the response headers
were sent, but not the full response. As stated in the RFC 9113, when the
response was fully sent, to stop the request sending, a RST_STREAM with an
error code of NO_ERROR must be sent.

This patch should solve the issue #1219. It must be backported to all stable
versions.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 68ad3eb3d..948ae26d3 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -5540,8 +5540,11 @@ static void h2_do_shutr(struct h2s *h2s, struct se_abort_info *reason)
 		 * stream anymore. This may happen when the server responds
 		 * before the end of an upload and closes quickly (redirect,
 		 * deny, ...)
+		 *
+		 * RFC9113#8.1: Use NO_ERROR code after a complete response was
+		 *              sent (So frontend side and ES sent)
 		 */
-		h2s_error(h2s, H2_ERR_CANCEL);
+		h2s_error(h2s, (!(h2c->flags & H2_CF_IS_BACK) && (h2s->flags & H2_SF_ES_SENT)) ? H2_ERR_NO_ERROR : H2_ERR_CANCEL);
 	}
 
 	if (!(h2s->flags & H2_SF_RST_SENT) &&