From: Christopher Faulet <cfaulet@haproxy.com>
Date: Fri, 14 Apr 2023 07:45:41 +0000 (+0200)
Subject: MEDIUM: stconn: Forbid applets with more to deliver if EOI was reached
X-Git-Tag: v2.8-dev8~143
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e8bcef5f2277b76e053415cf67b3cbbab78adc29;p=thirdparty%2Fhaproxy.git

MEDIUM: stconn: Forbid applets with more to deliver if EOI was reached

When an applet is woken up, before calling its io_handler, we pretend it has
no more data to deliver. So, after the io_handler execution, it is a bug if
an applet states it has more data to deliver while the end of input is
reached.

So a BUG_ON() is added to be sure it never happens.
---

diff --git a/src/stconn.c b/src/stconn.c
index f6ca85aff9..1ec6172b02 100644
--- a/src/stconn.c
+++ b/src/stconn.c
@@ -1847,6 +1847,8 @@ static int sc_applet_process(struct stconn *sc)
 		sc_abort(sc);
 	}
 
+	BUG_ON(sc_ep_test(sc, SE_FL_HAVE_NO_DATA|SE_FL_EOI) == SE_FL_EOI);
+
 	/* If the applet wants to write and the channel is closed, it's a
 	 * broken pipe and it must be reported.
 	 */