From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Sun, 22 Sep 2024 15:31:23 +0000 (+0100)
Subject: Revert "copy-firmware: Support additional compressor options"
X-Git-Tag: 20241017~9^2~8
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e8f8537768aaa8d991477155ac00f7826457515e;p=thirdparty%2Flinux-firmware.git

Revert "copy-firmware: Support additional compressor options"

This reverts commit 2bad80e7edd3c0f84718545d9338c8edfed16513.

The commit effectively added accidental command injection, while it was aiming
to control the compression flags.

In practise you'd want to use ZSTD_CLEVEL and ZSTD_NBTHREADS for zstd. As
documented in zstd(1) it allows for up-to level 19, which is fine since the
kernel does not support higher levels.

Arch, Alpine and likely other distributions have been using this approach
since day one.

The other compressors like xz have equivalent.

Cc: Juerg Haefliger <juerg.haefliger@canonical.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---

diff --git a/copy-firmware.sh b/copy-firmware.sh
index 344f478d..21ed20d5 100755
--- a/copy-firmware.sh
+++ b/copy-firmware.sh
@@ -44,14 +44,6 @@ while test $# -gt 0; do
             shift
             ;;
 
-        -*)
-            if test "$compress" = "cat"; then
-                echo "ERROR: unknown command-line option: $1"
-                exit 1
-            fi
-            compress="$compress $1"
-            shift
-            ;;
         *)
             if test "x$destdir" != "x"; then
                 echo "ERROR: unknown command-line options: $*"