From: Thomas Schwinge <thomas@codesourcery.com>
Date: Thu, 23 Mar 2023 11:32:35 +0000 (+0100)
Subject: Add caveat/safeguard to OpenMP: Handle descriptors in target's firstprivate [PR104949]
X-Git-Tag: basepoints/gcc-14~355
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e8fec6998b656dac02d4bc6c69b35a0fb5611e87;p=thirdparty%2Fgcc.git

Add caveat/safeguard to OpenMP: Handle descriptors in target's firstprivate [PR104949]

Follow-up to commit 49d1a2f91325fa8cc011149e27e5093a988b3a49
"OpenMP: Handle descriptors in target's firstprivate [PR104949]".

	PR fortran/104949
	libgomp/
	* target.c (gomp_map_vars_internal) <GOMP_MAP_FIRSTPRIVATE>: Add
	caveat/safeguard.
---

diff --git a/libgomp/target.c b/libgomp/target.c
index 90b4204133a7..b30c6a50c7e2 100644
--- a/libgomp/target.c
+++ b/libgomp/target.c
@@ -1396,6 +1396,11 @@ gomp_map_vars_internal (struct gomp_device_descr *devicep,
 		  {
 		    uintptr_t target = (uintptr_t) hostaddrs[i];
 		    void *devptr = *(void**) hostaddrs[i+1] + sizes[i+1];
+		    /* Per
+		       <https://inbox.sourceware.org/gcc-patches/87o7pe12ke.fsf@euler.schwinge.homeip.net>
+		       "OpenMP: Handle descriptors in target's firstprivate [PR104949]"
+		       this probably needs revision for 'aq' usage.  */
+		    assert (!aq);
 		    gomp_copy_host2dev (devicep, aq, devptr, &target,
 					sizeof (void *), false, cbufp);
 		    ++i;