From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 3 Aug 2011 22:49:04 +0000 (+0100)
Subject: hw/qdev: Don't crash if qdev_create(NULL, ...) fails
X-Git-Tag: v1.0-rc0~515^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e92714c71a2f50b8420126e952cadb653fa0ef93;p=thirdparty%2Fqemu.git

hw/qdev: Don't crash if qdev_create(NULL, ...) fails

If an attempt to create a qdev device on the default sysbus (by passing
NULL as the bus to qdev_create) fails, print a useful error message
rather than crashing trying to dereference a NULL pointer.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---

diff --git a/hw/qdev.c b/hw/qdev.c
index 6819537648f..d8114c6d93a 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -111,7 +111,12 @@ DeviceState *qdev_create(BusState *bus, const char *name)
 
     dev = qdev_try_create(bus, name);
     if (!dev) {
-        hw_error("Unknown device '%s' for bus '%s'\n", name, bus->info->name);
+        if (bus) {
+            hw_error("Unknown device '%s' for bus '%s'\n", name,
+                     bus->info->name);
+        } else {
+            hw_error("Unknown device '%s' for default sysbus\n", name);
+        }
     }
 
     return dev;