From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 26 Aug 2020 21:08:11 +0000 (-0400)
Subject: Suppress compiler warning in non-cassert builds.
X-Git-Tag: REL_14_BETA1~1779
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=e942af7b8261cd8070d0eeaf518dbc1a664859fd;p=thirdparty%2Fpostgresql.git

Suppress compiler warning in non-cassert builds.

Oversight in 808e13b28, reported by Bruce Momjian.

Discussion: https://postgr.es/m/20200826160251.GB21909@momjian.us
---

diff --git a/src/backend/storage/file/sharedfileset.c b/src/backend/storage/file/sharedfileset.c
index 65fd8ff5c0c..8b96e81ffff 100644
--- a/src/backend/storage/file/sharedfileset.c
+++ b/src/backend/storage/file/sharedfileset.c
@@ -285,7 +285,6 @@ SharedFileSetDeleteOnProcExit(int status, Datum arg)
 void
 SharedFileSetUnregister(SharedFileSet *input_fileset)
 {
-	bool		found = false;
 	ListCell   *l;
 
 	/*
@@ -303,12 +302,12 @@ SharedFileSetUnregister(SharedFileSet *input_fileset)
 		if (input_fileset == fileset)
 		{
 			filesetlist = list_delete_cell(filesetlist, l);
-			found = true;
-			break;
+			return;
 		}
 	}
 
-	Assert(found);
+	/* Should have found a match */
+	Assert(false);
 }
 
 /*